Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift6] Change Response to struct #20185

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

x-sheep
Copy link
Contributor

@x-sheep x-sheep commented Nov 26, 2024

This PR changes the Response open class to a struct. This is a breaking change, but I think there's a lot of benefits to not allowing Response to be overridden. The primary benefit is conformance to Sendable, which is important for Swift 6 specifically.

@jgavris @ehyche @Edubits @jaz-ah @4brunu @dydus0x14

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@x-sheep x-sheep force-pushed the swift6-response-struct branch from 66791e7 to 1e16bf6 Compare November 26, 2024 07:50
@4brunu
Copy link
Contributor

4brunu commented Nov 26, 2024

Looks good to me 👍
In case someone needs to override the response, we can introduce a flag to allow it.

@4brunu 4brunu merged commit 55f02e9 into OpenAPITools:master Nov 26, 2024
17 checks passed
@x-sheep x-sheep deleted the swift6-response-struct branch November 26, 2024 08:53
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants