Fix bug in common path prefix calculation in Helidon generators #20310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20298
The Helidon generator contains code to calculate the longest common prefix among paths to help optimize the grouping of operations into services.
As described in the bug, the original implementation essentially compared character-by-character which led to problems if paths agreed partway through a segment. For example, given the paths "/a/part-one" and "/a/part-two" the code would incorrectly yield a common prefix of "a/part-" when it should have been "/a".
The PR revises the calculation so it examines corresponding segments rather than corresponding characters of the paths.
The PR includes additional tests to more thoroughly check the implementation.
(Also, the PR updates the hard-coded current latest releases of Helidon used by the generator if the user does not specify a Helidon version and if the available versions are not available on the network.)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)