Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] adjust multi-constraint dependency syntax to comply with PEP 508 #20458

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

bachorp
Copy link
Contributor

@bachorp bachorp commented Jan 13, 2025

The current syntax is compatible with Poetry. However, it seems to cause issues with some other tools (#19694 (comment)) and does not comply with the corresponding PEP (https://peps.python.org/pep-0508/#complete-grammar).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bachorp
Copy link
Contributor Author

bachorp commented Jan 13, 2025

Test failure seems unrelated. Error can be reproduced at https://petstore.swagger.io/v2/pet/findByTags?tags=a&tags=a.

FAILED tests/test_api_validation.py::ApiExceptionTests::test_set_param_validation - petstore_api.exceptions.ServiceException: (500)
Reason: Server Error
HTTP response headers: HTTPHeaderDict({'Date': 'Mon, 13 Jan 2025 21:03:02 GMT', 'Content-Type': 'application/json', 'Transfer-Encoding': 'chunked', 'Connection': 'keep-alive', 'Access-Control-Allow-Origin': '*', 'Access-Control-Allow-Methods': 'GET, POST, DELETE, PUT', 'Access-Control-Allow-Headers': 'Content-Type, api_key, Authorization', 'Server': 'Jetty(9.2.9.v20150224)'})
HTTP response body: {"code":500,"type":"unknown","message":"something bad happened"}

@wing328
Copy link
Member

wing328 commented Jan 14, 2025

cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@wing328 wing328 merged commit 61bdc6b into OpenAPITools:master Jan 14, 2025
36 checks passed
@wing328
Copy link
Member

wing328 commented Jan 14, 2025

thanks for the PR, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants