Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outer enum number bug elixir generator #20592

Conversation

montague
Copy link
Contributor

@montague montague commented Feb 4, 2025

This is a more complete fix for a bug where an outer enum isn't properly deserialized in the generated Elixir client. See this issue. #16412

My previous PR (#20587) addressed the outer enum string bug. This follow-up PR fixes the issue more generally and updates the relevant test to ensure other outer enum types work as expected.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This PR is a follow up bug fix in the Elixir generator @mrmstn (see previous PR #20587)

@montague
Copy link
Contributor Author

montague commented Feb 4, 2025

@tobbbles this fixes the issue from #16412 more generally.

@wing328 wing328 added this to the 7.12.0 milestone Feb 5, 2025
@wing328 wing328 merged commit 248a78b into OpenAPITools:master Feb 5, 2025
16 checks passed
@wing328
Copy link
Member

wing328 commented Feb 5, 2025

thanks for the PR. lgtm. let's give it a try

@montague montague deleted the fix-outer-enum-number-bug-elixir-generator branch February 5, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants