Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby fix typhoeus api client multiple call with file return type #20615

Conversation

maximevct
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Hi @cliffano @zlx @autopp,
When downloading File type with Typhoeus request was run two times, one in call_api method as it should be and another in download_file to ensure the file is available before a check. The call should only happen once.
I've written a fix but not quite fond of the outcome.

@wing328
Copy link
Member

wing328 commented Feb 9, 2025

I've written a fix but not quite fond of the outcome.

thanks for the PR. did you test the locally? do you mean the fix still has the double download issue?

@maximevct
Copy link
Contributor Author

I've written a fix but not quite fond of the outcome.

thanks for the PR. did you test the locally? do you mean the fix still has the double download issue?

No I tested it and the fix works fine. I just think the code I wrote is not very elegant

@wing328 wing328 added this to the 7.12.0 milestone Feb 17, 2025
@wing328
Copy link
Member

wing328 commented Feb 17, 2025

ok. let's go with what you've so far and see if others want to contribute a PR to further enhance your fix.

@wing328 wing328 merged commit 515c882 into OpenAPITools:master Feb 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants