Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Fixed discriminator #20624

Merged
merged 8 commits into from
Feb 9, 2025
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 9, 2025

based on #20572 with updated samples

Fixes #19691

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 marked this pull request as ready for review February 9, 2025 14:26
@wing328 wing328 changed the title Devhl labs 19691 fix discriminator [csharp] Fixed discriminator Feb 9, 2025
@wing328 wing328 merged commit 61262e9 into master Feb 9, 2025
93 of 98 checks passed
@wing328 wing328 deleted the devhl-labs-19691-fix-discriminator branch February 9, 2025 14:32
@wing328 wing328 added this to the 7.12.0 milestone Feb 9, 2025
@wing328 wing328 mentioned this pull request Feb 9, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [CSHARP] Wrong code generated for discriminator property when enum is used
2 participants