Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Fix ruby client generator to generate setter methods with not null validation #20672

Conversation

yujideveloper
Copy link
Contributor

@yujideveloper yujideveloper commented Feb 17, 2025

Not null validation was missing for required and non-nullable properties when no other validation was present.
In this changes, it now behaves the same as #valid? and #list_invalid_properties.
And fix an issue where the initialize method did not accept attributes defined in its parent class.

related: #16114, #15895

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

…ll validation

Not null validation was missing for required and non-nullable properties when
no other validation was present.
@yujideveloper yujideveloper force-pushed the bugfix/missing-not-null-validation-on-ruby-client branch from 260f27c to 2846ac4 Compare February 17, 2025 11:31
@yujideveloper yujideveloper force-pushed the bugfix/missing-not-null-validation-on-ruby-client branch from 74f533a to b583a0f Compare February 18, 2025 08:19
@yujideveloper yujideveloper marked this pull request as ready for review February 18, 2025 08:32
@wing328 wing328 added this to the 7.12.0 milestone Feb 18, 2025
@wing328
Copy link
Member

wing328 commented Feb 19, 2025

thanks for the PR

let's give it a try

@wing328 wing328 merged commit c349270 into OpenAPITools:master Feb 19, 2025
19 checks passed
@yujideveloper yujideveloper deleted the bugfix/missing-not-null-validation-on-ruby-client branch February 19, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants