Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs-express-server): update express-openapi-validator to v4 #20704

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

gus-costa
Copy link
Contributor

Update express-openapi-validator from v3 to v4 to support Node.js versions >14.

This includes:

  • Upgrade express-openapi-validator dependency in package.json
  • Modify server startup code to accommodate v4 API changes
  • Update controller implementation to handle breaking changes

The changes ensure compatibility with modern Node.js versions while maintaining the generator's functionality.

fix #13245
fix #20258
fix #11568

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

Update express-openapi-validator from v3 to v4 to support Node.js versions >14.
This includes:
- Upgrade express-openapi-validator dependency in package.json
- Modify server startup code to accommodate v4 API changes
- Update controller implementation to handle breaking changes

The changes ensure compatibility with modern Node.js versions while maintaining
the generator's functionality.
@wing328 wing328 merged commit 86a293e into OpenAPITools:master Feb 23, 2025
15 checks passed
@wing328 wing328 added this to the 7.12.0 milestone Feb 23, 2025
@wing328
Copy link
Member

wing328 commented Feb 23, 2025

samples updated via b804613

@gus-costa gus-costa deleted the expressserver-nodegt14 branch February 24, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment