Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RST IoC Lookup] Add RST IoC Lookup connector. + Fixes for Report Hub and Threat Feed #2864

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

k1r10n
Copy link
Contributor

@k1r10n k1r10n commented Oct 29, 2024

Proposed changes

  • A new RST IoC Lookup Connector: cost-effective and functional enrichment connector for observables and indicators
  • New parameters to give options for users to disable/enable generation of 'related-to' and observables when using the RST Report Hub connector
  • Minor fixes to RST Threat Feed connector: indicator patterns standardised, only_new logic changed, code reformatting, description are nulled for high level objects as intrusion-set, malware, tools, etc profiles are to come from RST Threat Library

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @k1r10n , thank you for your PR and this new connector!

As I wrote in the comments, there is an issue with CONNECTOR_UPDATE_EXISTING_DATA env var:

  • rst-threat-hub doesn't ingest anything as VALIDATION_ERROR is raised for each message
  • rst-threat-feed ingests data and I didn't see any VALIDATION_ERROR so far (there are many MISSING_REFERENCE_ERROR but it's already the case on master, your fixes/updates are not responsible)
  • I tested rst-ioc-lookup manually and in auto mode, it seems to working as intended in both ways

FIY, all my tests have been done by running connectors locally with env vars set in config.yml.

Could you fix the issue in the comments so we can merge your PR please? Thanks 😇

@Powlinett Powlinett added the community use to identify PR from community label Nov 13, 2024
@k1r10n
Copy link
Contributor Author

k1r10n commented Dec 2, 2024

Hi @Powlinett, this PR has been open for a while. Please take a look and merge it when you have time.

@k1r10n
Copy link
Contributor Author

k1r10n commented Jan 5, 2025

Happy New Year! :)

@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 7, 2025
helene-nguyen
helene-nguyen previously approved these changes Jan 8, 2025
@helene-nguyen helene-nguyen dismissed their stale review January 8, 2025 09:46

Need commits to be signed

Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please sign your commits ?

@helene-nguyen helene-nguyen self-assigned this Jan 8, 2025
@helene-nguyen
Copy link
Member

@k1r10n Thank you so much for your effort! All commits need to have verified signatures. Would you mind adding that when you get a chance? 😊

@helene-nguyen
Copy link
Member

@k1r10n Sorry again, all commits need to have verified signatures and some haven't. Would you mind adding that ?

@k1r10n k1r10n force-pushed the rstcloud-Oct-2024-fixes branch from 2117ba4 to 2f67336 Compare January 16, 2025 00:30
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution ! Everything looks great on our end :)

@helene-nguyen helene-nguyen changed the title Added RST IoC Lookup connector. Fixes for Report Hub and Threat Feed [RST IoC Lookup] Add RST IoC Lookup connector. + Fixes for Report Hub and Threat Feed Jan 16, 2025
@helene-nguyen helene-nguyen linked an issue Jan 16, 2025 that may be closed by this pull request
@helene-nguyen helene-nguyen merged commit a2ce4ed into OpenCTI-Platform:master Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
4 participants