-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RST IoC Lookup] Add RST IoC Lookup connector. + Fixes for Report Hub and Threat Feed #2864
[RST IoC Lookup] Add RST IoC Lookup connector. + Fixes for Report Hub and Threat Feed #2864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @k1r10n , thank you for your PR and this new connector!
As I wrote in the comments, there is an issue with CONNECTOR_UPDATE_EXISTING_DATA
env var:
- rst-threat-hub doesn't ingest anything as
VALIDATION_ERROR
is raised for each message - rst-threat-feed ingests data and I didn't see any
VALIDATION_ERROR
so far (there are manyMISSING_REFERENCE_ERROR
but it's already the case on master, your fixes/updates are not responsible) - I tested rst-ioc-lookup manually and in auto mode, it seems to working as intended in both ways
FIY, all my tests have been done by running connectors locally with env vars set in config.yml
.
Could you fix the issue in the comments so we can merge your PR please? Thanks 😇
Hi @Powlinett, this PR has been open for a while. Please take a look and merge it when you have time. |
Happy New Year! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please sign your commits ?
@k1r10n Thank you so much for your effort! All commits need to have verified signatures. Would you mind adding that when you get a chance? 😊 |
@k1r10n Sorry again, all commits need to have verified signatures and some haven't. Would you mind adding that ? |
2117ba4
to
2f67336
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution ! Everything looks great on our end :)
Proposed changes
Related issues
Checklist
Further comments