Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sentinel-Intel] Fix Error 401 Unauthorized #3041

Merged
merged 3 commits into from
Nov 27, 2024
Merged

[Sentinel-Intel] Fix Error 401 Unauthorized #3041

merged 3 commits into from
Nov 27, 2024

Conversation

Megafredo
Copy link
Member

Proposed changes

  • Implementation of a retries builder to handle 429 errors (Too Many Requests)
  • Improved error handling with more detailed messages
  • Addition of a systematic token validity check before each request, with automatic renewal if necessary

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@Megafredo Megafredo added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team critical use to identify critical bug to fix ASAP labels Nov 27, 2024
@Megafredo Megafredo self-assigned this Nov 27, 2024
@Megafredo Megafredo linked an issue Nov 27, 2024 that may be closed by this pull request
[sentinel-intel] JWT token expire after two hours and is not renewed #3032
Closed
flavienSindou
flavienSindou approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements !
🥳

@Megafredo Megafredo merged commit d85ec9a into master Nov 27, 2024
4 checks passed
@Megafredo Megafredo deleted the bug/3032-sentinel-intel branch November 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavienSindou flavienSindou flavienSindou approved these changes

@Powlinett Powlinett Awaiting requested review from Powlinett

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@Megafredo Megafredo

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sentinel-intel] JWT token expire after two hours and is not renewed
2 participants
@Megafredo @flavienSindou