Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ThreatMatch] Added Beautifulsoup parsing and cleaned up code #3047

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

pietrocapece
Copy link
Contributor

@pietrocapece pietrocapece commented Nov 28, 2024

Proposed changes

  • Added HTML parsing of the content of alerts with Beautifulsoup
  • Removed some legacy code that was commented out

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the community use to identify PR from community label Dec 5, 2024
@flavienSindou flavienSindou changed the title Added Beautifulsoup parsing and cleaned up code [ThreatMatch] Added Beautifulsoup parsing and cleaned up code Dec 24, 2024
@flavienSindou flavienSindou added partner used to identify PR from patner and removed community use to identify PR from community labels Dec 24, 2024
@flavienSindou flavienSindou self-requested a review December 24, 2024 13:46
@flavienSindou
Copy link
Contributor

@pietrocapece Thank you for the feature addition and for cleaning up the code!

I noticed that the requirements file needs to be updated to resolve the merge conflict. Once that's done, I’ll be happy to approve your pull request.

@richard-julien richard-julien force-pushed the master branch 2 times, most recently from 9818df2 to 0f4b30d Compare February 4, 2025 14:35
@SamuelHassine SamuelHassine force-pushed the master branch 2 times, most recently from b513b96 to 11a05bf Compare February 14, 2025 12:49
@flavienSindou flavienSindou self-requested a review February 21, 2025 10:50
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavienSindou flavienSindou self-requested a review February 21, 2025 10:59
@flavienSindou flavienSindou self-requested a review February 21, 2025 11:03
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please sign this commit
310cc90
the merge pipeline requests all commits are signed

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@flavienSindou
Copy link
Contributor

@pietrocapece

The requirements file needs to be updated to resolve the merge conflict.

Could you please sign this commit
310cc90
the merge pipeline requests all commits are signed

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Best regards.

@pietrocapece
Copy link
Contributor Author

So i keep having to update the requirements because you keep updating the app. Pleawe could you just merge my code so I dont have to keep doing this? I cannot sign the commits unfortunately, I have tried for months but the feature is not working from the linux subsystem I am working from. Happy to find another way to deliver this code foer you to upload but I am unable to sign the commits, and it is impossible to sign them retroactively.

@flavienSindou flavienSindou self-requested a review February 26, 2025 13:09
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge a PR with unsigned commit and cannot make an exception.

Please find below a detailed procedure to sign your commit retroactively.

https://webdevstudios.com/2020/05/26/retroactively-sign-git-commits/

@helene-nguyen helene-nguyen dismissed flavienSindou’s stale review February 27, 2025 07:08

Remove request changes as discussed with Flavien

@helene-nguyen helene-nguyen linked an issue Feb 27, 2025 that may be closed by this pull request
@helene-nguyen helene-nguyen merged commit 6ac481b into OpenCTI-Platform:master Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner used to identify PR from patner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ThreatMatch] refacto: code improvements
3 participants