-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ThreatMatch] Added Beautifulsoup parsing and cleaned up code #3047
Conversation
@pietrocapece Thank you for the feature addition and for cleaning up the code! I noticed that the requirements file needs to be updated to resolve the merge conflict. Once that's done, I’ll be happy to approve your pull request. |
9818df2
to
0f4b30d
Compare
b513b96
to
11a05bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please sign this commit
310cc90
the merge pipeline requests all commits are signed
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
The requirements file needs to be updated to resolve the merge conflict. Could you please sign this commit https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits Best regards. |
So i keep having to update the requirements because you keep updating the app. Pleawe could you just merge my code so I dont have to keep doing this? I cannot sign the commits unfortunately, I have tried for months but the feature is not working from the linux subsystem I am working from. Happy to find another way to deliver this code foer you to upload but I am unable to sign the commits, and it is impossible to sign them retroactively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot merge a PR with unsigned commit and cannot make an exception.
Please find below a detailed procedure to sign your commit retroactively.
https://webdevstudios.com/2020/05/26/retroactively-sign-git-commits/
Remove request changes as discussed with Flavien
Proposed changes
Related issues
Checklist
Further comments