-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tagger] Add a capacity to the Tagger connector #3065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code contains duplication. Could you consider refactoring it please?
Hi @flavienSindou, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work !
I made a few remarks but functional tests are ok.
Co-authored-by: flavienSindou <[email protected]>
Co-authored-by: flavienSindou <[email protected]>
Co-authored-by: flavienSindou <[email protected]>
Proposed changes
Related issues
Checklist
Further comments
Need to be tested using the two new attributes available: