Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagger] Add a capacity to the Tagger connector #3065

Merged
merged 9 commits into from
Dec 5, 2024
Merged

[Tagger] Add a capacity to the Tagger connector #3065

merged 9 commits into from
Dec 5, 2024

Conversation

Lhorus6
Copy link
Contributor

@Lhorus6 Lhorus6 commented Dec 4, 2024

Proposed changes

  • Two new attributes available to act based on contained entities of container (e.g. Report)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Need to be tested using the two new attributes available:

  • objects-type
  • objects-name

@Lhorus6 Lhorus6 linked an issue Dec 4, 2024 that may be closed by this pull request
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code contains duplication. Could you consider refactoring it please?

@Lhorus6
Copy link
Contributor Author

Lhorus6 commented Dec 4, 2024

Hi @flavienSindou,
I made few modifications. Can you please tell me if this is what you expected?
If not, can you give me some guidelines?

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Dec 5, 2024
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work !

I made a few remarks but functional tests are ok.

@Lhorus6 Lhorus6 merged commit 86a6a78 into master Dec 5, 2024
0 of 4 checks passed
@Lhorus6 Lhorus6 deleted the issue/3064 branch December 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tagger] Add a capacity to the Tagger connector
3 participants