Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create IBM X-Force Premier Threat Intelligence Services connector for OpenCTI platform #3111

Merged
merged 13 commits into from
Jan 17, 2025
Merged

Create IBM X-Force Premier Threat Intelligence Services connector for OpenCTI platform #3111

merged 13 commits into from
Jan 17, 2025

Conversation

awarrier99
Copy link
Contributor

@awarrier99 awarrier99 commented Dec 11, 2024 •
edited by helene-nguyen
Loading

Proposed changes

  • Create IBM XTI OpenCTI connector

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@romain-filigran romain-filigran added the partner used to identify PR from patner label Dec 12, 2024
awarrier99 and others added 6 commits December 16, 2024 13:59
@awarrier99
Improve thread synchronization, evaluate added_after from only primar…
2a888a6 
…y objects, and fix formatting errors
@awarrier99
Merge pull request #3 from ibm-xti/code-review-updates
f271be0 
Improve thread synchronization, evaluate added_after from only primary objects, and fix formatting errors
@awarrier99
Sort imports
9532d26
@ibm-xti
Merge pull request #4 from ibm-xti/sort-imports
1e43670 
Sort imports
@awarrier99
Address formatting errors
3bc0bd2
@ibm-xti
Merge pull request #5 from ibm-xti/formatting-errors
8045e17 
Address formatting errors
@helene-nguyen helene-nguyen self-assigned this Jan 15, 2025
@helene-nguyen
Copy link
Member

@awarrier99 Thank you for your contribution ! Everything looks great on our end! Could you add some documentation to explain the behavior of the connector?

@awarrier99
Copy link
Contributor Author

awarrier99 commented Jan 15, 2025 •
edited
Loading

@awarrier99 Thank you for your contribution ! Everything looks great on our end! Could you add some documentation to explain the behavior of the connector?

Hi @helene-nguyen, sure thing we have added some now! Please let us know if you would like us to squash these commits down into one to make the commit history a little cleaner, or if that will already be handled by your merge strategy.

@helene-nguyen
Copy link
Member

@awarrier99 thank you for completing the documentation! You don't need to squash the commits, thank you, it will be handled by the merge strategy

@helene-nguyen helene-nguyen linked an issue Jan 17, 2025 that may be closed by this pull request
[IBM XTI] Create IBM XTI OpenCTI connector #3308
Closed
@helene-nguyen helene-nguyen merged commit fbd6df2 into OpenCTI-Platform:master Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees

@helene-nguyen helene-nguyen

Labels
partner used to identify PR from patner
Projects
None yet
Milestone
PRs backlog
Development

Successfully merging this pull request may close these issues.

[IBM XTI] Create IBM XTI OpenCTI connector
4 participants
@awarrier99 @helene-nguyen @romain-filigran @ibm-xti