Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[attribution-tools] Install gfortran, openblas, xsimd #3115

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

ckane
Copy link
Contributor

@ckane ckane commented Dec 12, 2024

Proposed changes

  • Install openblas, gfortran, and xsimd in attribution-tools container

The build of the container for attribution-tools appears broken now, at least on ARM64 architecture. Not sure if it's also broken on x86-64 (I presume it is fine there?).

Installing dependencies OpenBLAS and gFortran seem to fix the breakage.

During fixing, I also noticed that some of the Python code will use xsimd if it is available. As this could potentially speed up analysis by leveraging streaming instructions, I figured I would add this as well to the container.

Related issue

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@ckane ckane changed the title [attribution-tools] Install gfortran, openblas, xsimd BUGFIX: [attribution-tools] Install gfortran, openblas, xsimd Dec 12, 2024
@ckane ckane force-pushed the fix-attribution-tools branch from 951e4f5 to 329933e Compare December 24, 2024 22:51
@nino-filigran nino-filigran added the community use to identify PR from community label Jan 3, 2025
@ckane ckane force-pushed the fix-attribution-tools branch from 329933e to 0c05530 Compare January 10, 2025 22:51
@ckane ckane force-pushed the fix-attribution-tools branch from 0c05530 to d514c37 Compare January 28, 2025 00:29
@richard-julien richard-julien force-pushed the master branch 2 times, most recently from 9818df2 to 0f4b30d Compare February 4, 2025 14:35
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckane thank you for the changes, could you rebase with master to update your branch to allow us to merge your PR ?

@helene-nguyen helene-nguyen self-assigned this Feb 6, 2025
@ckane ckane force-pushed the fix-attribution-tools branch from d514c37 to 5dce05e Compare February 6, 2025 14:49
@ckane
Copy link
Contributor Author

ckane commented Feb 6, 2025

Thanks @helene-nguyen - done!

Copy link
Contributor Author

@ckane ckane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased

@ckane ckane force-pushed the fix-attribution-tools branch from 5dce05e to a8aefd4 Compare February 12, 2025 13:00
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ckane, sorry for the delay !

@helene-nguyen helene-nguyen changed the title BUGFIX: [attribution-tools] Install gfortran, openblas, xsimd [attribution-tools] Install gfortran, openblas, xsimd Feb 13, 2025
@SamuelHassine SamuelHassine force-pushed the master branch 2 times, most recently from b513b96 to 11a05bf Compare February 14, 2025 12:49
@ckane ckane force-pushed the fix-attribution-tools branch from a8aefd4 to 5433c7e Compare February 18, 2025 14:53
@helene-nguyen helene-nguyen linked an issue Feb 24, 2025 that may be closed by this pull request
@helene-nguyen helene-nguyen merged commit 90f3540 into OpenCTI-Platform:master Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[attribution-tools] Install gfortran, openblas, xsimd
3 participants