-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[attribution-tools] Install gfortran, openblas, xsimd #3115
[attribution-tools] Install gfortran, openblas, xsimd #3115
Conversation
951e4f5
to
329933e
Compare
329933e
to
0c05530
Compare
0c05530
to
d514c37
Compare
9818df2
to
0f4b30d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckane thank you for the changes, could you rebase with master to update your branch to allow us to merge your PR ?
d514c37
to
5dce05e
Compare
Thanks @helene-nguyen - done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased
5dce05e
to
a8aefd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ckane, sorry for the delay !
b513b96
to
11a05bf
Compare
a8aefd4
to
5433c7e
Compare
Proposed changes
openblas
,gfortran
, andxsimd
in attribution-tools containerThe build of the container for
attribution-tools
appears broken now, at least on ARM64 architecture. Not sure if it's also broken on x86-64 (I presume it is fine there?).Installing dependencies OpenBLAS and gFortran seem to fix the breakage.
During fixing, I also noticed that some of the Python code will use
xsimd
if it is available. As this could potentially speed up analysis by leveraging streaming instructions, I figured I would add this as well to the container.Related issue
Checklist