Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[urlscan-enrichment] Make indicator creation optional #3139

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[urlscan-enrichment] Make indicator creation optional #3139

merged 1 commit into from
Feb 24, 2025

Conversation

DucNg
Copy link
Contributor

@DucNg DucNg commented Dec 13, 2024 •
edited by helene-nguyen
Loading

Proposed changes

  • Make indicator creation optional
  • Add a URLSCAN_ENRICHMENT_CREATE_INDICATOR variable to decide whether or not to create indicator when enrichment is done

Related issue

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@DucNg DucNg force-pushed the urlscan-optional-indicator branch from 106a1e4 to daaf14c Compare December 13, 2024 15:10
@romain-filigran romain-filigran added the community use to identify PR from community label Dec 27, 2024
@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 7, 2025
@DucNg
Copy link
Contributor Author

DucNg commented Jan 9, 2025

Gentle ping

@richard-julien richard-julien force-pushed the master branch 2 times, most recently from 9818df2 to 0f4b30d Compare February 4, 2025 14:35
@SamuelHassine SamuelHassine force-pushed the master branch 2 times, most recently from b513b96 to 11a05bf Compare February 14, 2025 12:49
@helene-nguyen helene-nguyen self-assigned this Feb 24, 2025
helene-nguyen
helene-nguyen approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @DucNg, sorry for the delay, everyhting look good to me :)

@helene-nguyen helene-nguyen linked an issue Feb 24, 2025 that may be closed by this pull request
[urlscan-enrichment] Make indicator creation optional #3477
Closed
@helene-nguyen helene-nguyen merged commit 5d00dc0 into OpenCTI-Platform:master Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees

@helene-nguyen helene-nguyen

Labels
community use to identify PR from community
Projects
None yet
Milestone
PRs backlog
Development

Successfully merging this pull request may close these issues.

[urlscan-enrichment] Make indicator creation optional
3 participants
@DucNg @helene-nguyen @romain-filigran