[Group-IB] Update Group-IB connector #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helene-nguyen
added
partner
yassine-ouaamou
changed the title
|
@Kchekh Thank you for the updated changes! We will have a review on this. Could you just sign your commits as it is required for merging the PR? |
|
Hello @helene-nguyen, |
|
@Kchekh Yes, sorry if it wasn't clear, it's signing with GPG key all the commits :) |
helene-nguyen
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change storage and change seqUpdate parameter in state OpenCTI
Global separation of environment parameters and config.yml to run locally or in docker
Small code edits
Related issues
Checklist
Further comments
I have made some changes to the code of our integration and would like to introduce them a bit.
The first thing that was done was to split the configs into config,yml to bring up the connector locally and .env file to run in Docker.
https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/src/config.yml.sample
https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/.env.sample
Since the formats of these files are different and our configuration has a lot of moment variables for the collection, we implemented a solution for automated collection in the file https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/src/config.py.
The work with SeqUpdate storage for our API was completely moved to OpenCTI state and at the moment SeqUpdate does not appear in environment variables or config.yml file, all work with it is done in https://github.com/Kchekh/connectors/blob/update/external-import/group-ib/src/lib/external_import.py file and with the help of state.
I ask you to check mentioned and other changes I’ve made, there are now in my repository: https://github.com/Kchekh/connectors/tree/update/external-import/group-ib