Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates] Fix syntax error on entity_in_scope in template #3249

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

DucNg
Copy link
Contributor

@DucNg DucNg commented Jan 9, 2025

Fix syntax error making the test always true

if self.entity_in_scope was always true

Proposed changes

  • Add a parameter to entity_in_scope so it actually runs the function instead of testing if it exists

Related issue

@helene-nguyen helene-nguyen added the community use to identify PR from community label Jan 14, 2025
@helene-nguyen
Copy link
Member

Thanks @DucNg :)

@helene-nguyen helene-nguyen linked an issue Jan 14, 2025 that may be closed by this pull request
@helene-nguyen helene-nguyen changed the title fix syntax error on entity_in_scope in template [Templates] Fix syntax error on entity_in_scope in template Jan 14, 2025
@helene-nguyen helene-nguyen self-assigned this Jan 14, 2025
@helene-nguyen helene-nguyen merged commit b096c05 into OpenCTI-Platform:master Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Templates] Fix syntax error on entity_in_scope in template
2 participants