Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zvelo]: Authentication token expiration not correctly managed #3296

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[Zvelo]: Authentication token expiration not correctly managed #3296

merged 1 commit into from
Jan 17, 2025

Conversation

romain-filigran
Copy link
Member

Proposed changes

  • Zvelo tokens expire over time. Updated code to request a token at each run.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@romain-filigran romain-filigran added the filigran team use to identify PR from the Filigran team label Jan 16, 2025
labo-flg
labo-flg approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise it seems ok.

@helene-nguyen helene-nguyen linked an issue Jan 17, 2025 that may be closed by this pull request
[Zvelo]: Authentication token expiration not correctly managed #3282
Closed
@helene-nguyen helene-nguyen merged commit 054abe2 into master Jan 17, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the issue/3282 branch January 17, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labo-flg labo-flg labo-flg approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Zvelo]: Authentication token expiration not correctly managed
3 participants
@romain-filigran @labo-flg @helene-nguyen