Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sekoia] Retrieve the list of entity sources #3299

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Conversation

Lhorus6
Copy link
Contributor

@Lhorus6 Lhorus6 commented Jan 17, 2025

Sekoia provides a list of sources who have reported the information. The information is contained in a custom Sekoia field, named "x_inthreat_sources_refs".

The various sources would have to be imported into the platform.

Proposed changes

  • Since STIX does not allow multiple “Author”, we record them in labels, e.g. “source:Name1”, “source:Name2”, ...

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@Lhorus6 Lhorus6 linked an issue Jan 17, 2025 that may be closed by this pull request
@Lhorus6 Lhorus6 changed the title Issue/3176 [Sekoia] Retrieve the list of entity sources Jan 17, 2025
@romain-filigran romain-filigran added the filigran team use to identify PR from the Filigran team label Jan 17, 2025
@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 17, 2025
@Lhorus6
Copy link
Contributor Author

Lhorus6 commented Jan 27, 2025

Hi @romain-filigran, @helene-nguyen,
It's a modification for a customer. Let me know when we can organize the review to validate the modification. We can do this together if it saves you time.

Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks for optimization but everything seems fine to me. Thanks you for your contribution !

@flavienSindou flavienSindou merged commit a2feae0 into master Feb 10, 2025
3 of 4 checks passed
@flavienSindou flavienSindou deleted the issue/3176 branch February 10, 2025 16:32
maximus-debski pushed a commit to maximus-debski/connectors that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sekoia] Retrieve the list of entity sources
3 participants