Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AbuseIPDB] Add more accurate logs when issue occurring outside the main process #3327

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[AbuseIPDB] Add more accurate logs when issue occurring outside the main process #3327

merged 1 commit into from
Jan 22, 2025

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Jan 21, 2025 •
edited
Loading

Proposed changes

  • Add more accurate logs when issue occurring outside the main process

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Jan 21, 2025
@helene-nguyen helene-nguyen self-assigned this Jan 21, 2025
@helene-nguyen helene-nguyen linked an issue Jan 21, 2025 that may be closed by this pull request
[AbuseIPDB] The connector completed with a "Terminated" status due to an issue occurring outside the main process #3326
Closed
Megafredo
Megafredo approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful update, it's ok for me ;)

@helene-nguyen helene-nguyen merged commit 5c970a0 into master Jan 22, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the bug/3326 branch January 22, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

@Powlinett Powlinett Awaiting requested review from Powlinett

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
2 participants
@helene-nguyen @Megafredo