Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stream-importer] refine metrics #3342

Merged
merged 7 commits into from
Feb 28, 2025
Merged

[stream-importer] refine metrics #3342

merged 7 commits into from
Feb 28, 2025

Conversation

axelfahy
Copy link
Contributor

@axelfahy axelfahy commented Jan 28, 2025 •
edited by helene-nguyen
Loading

Proposed changes

  • Refine the metrics of the stream-importer-connector
  • Disable perfect sync by default
  • Add namespace and subsystem for metrics
  • Refactor src and dst envs for minio to be more flexible

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@richard-julien richard-julien force-pushed the master branch 2 times, most recently from 9818df2 to 0f4b30d Compare February 4, 2025 14:35
@helene-nguyen helene-nguyen added the community use to identify PR from community label Feb 6, 2025
@axelfahy axelfahy force-pushed the feature/stream-importer-metrics branch from 3c9278d to 4b566d5 Compare February 14, 2025 10:39
@SamuelHassine SamuelHassine force-pushed the master branch 2 times, most recently from b513b96 to 11a05bf Compare February 14, 2025 12:49
@axelfahy axelfahy force-pushed the feature/stream-importer-metrics branch from 4b566d5 to 17769ed Compare February 14, 2025 14:58
@axelfahy axelfahy force-pushed the feature/stream-importer-metrics branch from 17769ed to b4c9f77 Compare February 14, 2025 15:17
@helene-nguyen helene-nguyen self-assigned this Feb 27, 2025
helene-nguyen
helene-nguyen approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement :)

@helene-nguyen helene-nguyen linked an issue Feb 28, 2025 that may be closed by this pull request
[stream-importer] refine metrics #3523
Closed
@helene-nguyen helene-nguyen merged commit f202a0a into OpenCTI-Platform:master Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees

@helene-nguyen helene-nguyen

Labels
community use to identify PR from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stream-importer] refine metrics
2 participants
@axelfahy @helene-nguyen