-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spycloud] Create external import connector #3347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c7d44e
to
abf331c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clear documented code.
Some small remarks but a really good implementation.
You should add a test-requirements.txt file for the CI to launch your tests
I test the connector locally and I'll approve it.
external-import/spycloud/tests/test_models/test_opencti_domain.py
Outdated
Show resolved
Hide resolved
external-import/spycloud/tests/test_models/test_opencti_domain.py
Outdated
Show resolved
Hide resolved
external-import/spycloud/tests/test_models/test_opencti_observables.py
Outdated
Show resolved
Hide resolved
external-import/spycloud/tests/test_models/test_opencti_observables.py
Outdated
Show resolved
Hide resolved
external-import/spycloud/tests/test_models/test_opencti_observables.py
Outdated
Show resolved
Hide resolved
flavienSindou
requested changes
Jan 31, 2025
MUST be deleted before merge into master
0ae8871
to
484f99c
Compare
flavienSindou
approved these changes
Feb 3, 2025
maximus-debski
pushed a commit
to maximus-debski/connectors
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not merge
Do not merge this PR until this tag will be removed
filigran team
use to identify PR from the Filigran team
new
use to identify new integration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist