Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spycloud] Create external import connector #3347

Merged
merged 50 commits into from
Feb 3, 2025

Conversation

Powlinett
Copy link
Member

Proposed changes

⚠️ This PR overrides previous Spycloud PR #3319

  • Use/adapt external import template
  • Validate config/env variables
  • Create Spycloud API client handling authentication, filters, retry strategy...
  • Create Spycloud classes (BreachCatalog and BreachRecord)
  • Create OpenCTI classes (Author, Incident, observables...)
  • Add unit tests
  • Add pyproject.toml
  • Update Docker build

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@Powlinett Powlinett added filigran team use to identify PR from the Filigran team do not merge Do not merge this PR until this tag will be removed new use to identify new integration labels Jan 29, 2025
@Powlinett Powlinett self-assigned this Jan 29, 2025
@Powlinett Powlinett linked an issue Jan 29, 2025 that may be closed by this pull request
@Powlinett Powlinett force-pushed the feature/2563-spycloud-observables branch from 2c7d44e to abf331c Compare January 29, 2025 16:57
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear documented code.
Some small remarks but a really good implementation.

You should add a test-requirements.txt file for the CI to launch your tests

I test the connector locally and I'll approve it.

@Powlinett Powlinett force-pushed the feature/2563-spycloud-observables branch from 0ae8871 to 484f99c Compare January 31, 2025 13:23
@Powlinett Powlinett merged commit cb0f5c1 into master Feb 3, 2025
4 checks passed
@Powlinett Powlinett deleted the feature/2563-spycloud-observables branch February 3, 2025 14:59
maximus-debski pushed a commit to maximus-debski/connectors that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR until this tag will be removed filigran team use to identify PR from the Filigran team new use to identify new integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SpyCloud] Create the connector
2 participants