Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proofpoint TAP] Init #3387

Merged
merged 4 commits into from
Feb 10, 2025
Merged

[Proofpoint TAP] Init #3387

merged 4 commits into from
Feb 10, 2025

Conversation

flavienSindou
Copy link
Contributor

@flavienSindou flavienSindou commented Feb 4, 2025 •
edited
Loading

Proposed changes

  • Create Proofpoint TAP connector with 2 simple use cases:
  1. Simple Report ingestion from Proofpoint TAP Campaign
  2. Simple Incident Ingestion fromm ProofPoint TAP Event

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Intermediate PRs

Further comments

https://www.notion.so/filigran/integration-Proofpoint-TAP-Developing-a-connector-d232cd64800a462296f2bc90bfb9d69f

Viz

  • Reports
    image
    image

  • Incidents
    image

@flavienSindou flavienSindou added the filigran team use to identify PR from the Filigran team label Feb 4, 2025
@flavienSindou flavienSindou self-assigned this Feb 4, 2025
@flavienSindou flavienSindou linked an issue Feb 4, 2025 that may be closed by this pull request
[Proofpoint TAP] Developing a connector #1538
Closed
@flavienSindou flavienSindou changed the title Proofpoint TAP] Init [Proofpoint TAP] Init Feb 4, 2025
Powlinett
Powlinett approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done on PRs #3343 and #3312 ✅

@flavienSindou flavienSindou merged commit 55b3984 into master Feb 10, 2025
4 checks passed
@flavienSindou flavienSindou deleted the feat/1538-proofpoint-tap-connector branch February 10, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Powlinett approved these changes

@Megafredo Megafredo Awaiting requested review from Megafredo

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@flavienSindou flavienSindou

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proofpoint TAP] Developing a connector
2 participants
@flavienSindou @Powlinett