Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProofPoint-ET-Intelligence] Create new enrichment connector #3392

Merged
merged 5 commits into from
Feb 12, 2025
Merged

[ProofPoint-ET-Intelligence] Create new enrichment connector #3392

merged 5 commits into from
Feb 12, 2025

Conversation

Megafredo
Copy link
Member

Proposed changes

WIP

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@Megafredo Megafredo added feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team labels Feb 5, 2025
@Megafredo Megafredo self-assigned this Feb 5, 2025
@Megafredo Megafredo linked an issue Feb 5, 2025 that may be closed by this pull request
[Proofpoint ET]: Create an enrichment connector #3075
Closed
Powlinett
Powlinett requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @Megafredo 👏 A LOT of work accomplished in a very short time 👏

After some tests:
⚠️ connector can be launched locally (see comments for config_variables.py)
⚠️ connector can be launched as a docker image (docker files are ok, but same issue with config_variables.py)
✅ Models seem accurate
✅ Scope checking work as intended (file's hash types)
✅ TLP checking work as intended
✅ Both automatic and manual enrichment work

@helene-nguyen helene-nguyen removed the feature use for describing a new feature to develop label Feb 6, 2025
@Megafredo Megafredo added the do not merge Do not merge this PR until this tag will be removed label Feb 6, 2025
@flavienSindou flavienSindou mentioned this pull request Feb 11, 2025
Open
helene-nguyen
helene-nguyen approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work done @Megafredo !

This PR can be merged as it is and some improvement is identified here to be added later:

@helene-nguyen helene-nguyen merged commit 125f601 into master Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Powlinett approved these changes

@helene-nguyen helene-nguyen helene-nguyen approved these changes

@flavienSindou flavienSindou Awaiting requested review from flavienSindou

Assignees

@Megafredo Megafredo

Labels
do not merge Do not merge this PR until this tag will be removed filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proofpoint ET]: Create an enrichment connector
4 participants
@Megafredo @Powlinett @helene-nguyen @flavienSindou