[SENTINEL-INTEL] fix: add explicit error when authentication fails #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavienSindou
added
bug
flavienSindou
requested review from
Megafredo,
Powlinett and
helene-nguyen
and removed request for
Megafredo
flavienSindou
commented
Feb 6, 2025
| @@ -38,6 +38,7 @@ def _get_authorization_header(self): | |||
| """ | |||
| Get an OAuth access token and set it as Authorization header in headers. | |||
| """ | |||
| response_json = {} | |||
There was a problem hiding this comment.
Init to be able to try to get content for error log
flavienSindou
commented
Feb 6, 2025
| @@ -48,16 +49,23 @@ def _get_authorization_header(self): | |||
| } | |||
| response = requests.post(url, data=body) | |||
| response_json = response.json() | |||
| response.raise_for_status() | |||
There was a problem hiding this comment.
core of the PR
|
|
||
| except Exception as e: | ||
| raise ValueError("[ERROR] Failed generating oauth token {" + str(e) + "}") | ||
| except (requests.exceptions.HTTPError, KeyError) as e: |
There was a problem hiding this comment.
core of the PR
There was a problem hiding this comment.
Thanks you @flavienSindou for adding this
Everything looks good to me :)
helene-nguyen
approved these changes
Feb 6, 2025
helene-nguyen
removed
the
bug
maximus-debski
pushed a commit
to maximus-debski/connectors
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
Notion investigation page https://www.notion.so/filigran/Sentinel-Intel-Connector-Not-Sending-Data-18b8fce17f2a80369730d92656219234