Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Virustotal Livehunt Notifications] Fix ModuleNotFound error #3398

Merged
merged 4 commits into from
Feb 10, 2025
Merged

[Virustotal Livehunt Notifications] Fix ModuleNotFound error #3398

merged 4 commits into from
Feb 10, 2025

Conversation

Powlinett
Copy link
Member

Proposed changes

  • Remove sys.exit() on uncaught exceptions (issue's fix)
  • Use self.helper.connector_logger logging functions (improvement)
  • Fix config.yml path to launch connector manually (other fix)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@Powlinett Powlinett self-assigned this Feb 7, 2025
@Powlinett Powlinett added the bug use for describing something not working as expected label Feb 7, 2025
@Powlinett Powlinett linked an issue Feb 7, 2025 that may be closed by this pull request
[virustotal-livehunt-notifications] Connector fails to start with ModuleNotFoundError: import of time halted; None in sys.modules #3334
Closed
helene-nguyen
helene-nguyen approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the issue and re-align with updated logger ✨
Everything looks good to me @Powlinett

@Powlinett Powlinett merged commit a60f88e into master Feb 10, 2025
4 checks passed
@Powlinett Powlinett deleted the issue/3334-virustotal-livehunt-notifications-module-not-found-error branch February 10, 2025 15:05
@helene-nguyen helene-nguyen added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 10, 2025
@helene-nguyen helene-nguyen added this to the Release 6.5.2 milestone Feb 10, 2025
@helene-nguyen helene-nguyen added filigran team use to identify PR from the Filigran team and removed solved use to identify issue that has been solved (must be linked to the solving PR) bug use for describing something not working as expected labels Feb 10, 2025
@helene-nguyen helene-nguyen removed this from the Release 6.5.2 milestone Feb 10, 2025
maximus-debski pushed a commit to maximus-debski/connectors that referenced this pull request Feb 26, 2025
@Powlinett @maximus-debski
[Virustotal Livehunt Notifications] Fix ModuleNotFound error (OpenCTI…
fd01408 
…-Platform#3398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

@Megafredo Megafredo Awaiting requested review from Megafredo

@flavienSindou flavienSindou Awaiting requested review from flavienSindou

Assignees

@Powlinett Powlinett

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
2 participants
@Powlinett @helene-nguyen