[Zvelo] hot fix: connector stops working if processed data is invalid or incorrectly formatted #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavienSindou
added
bug
flavienSindou
commented
Feb 10, 2025
| from stix2.exceptions import InvalidValueError | ||
|
|
||
|
|
||
| class ConverterError(Exception): |
There was a problem hiding this comment.
Core of the PR
| @@ -65,24 +65,25 @@ def _collect_intelligence(self, from_date: str) -> list[stix2.v21._STIXBase21]: | |||
| continue | |||
|
|
|||
| # Convert into STIX2 object and add it on a list | |||
| if collection == "threat": | |||
There was a problem hiding this comment.
Refacto and handling of the ConverterError
| @@ -119,6 +152,7 @@ def _create_relation( | |||
| ) | |||
| return stix_relationship | |||
|
|
|||
| @known_converter_error | |||
There was a problem hiding this comment.
Decorator to minimize code changes
| def wrapper(self, *args, **kwargs): | ||
| try: | ||
| return func(self, *args, **kwargs) | ||
| except InvalidValueError as error: |
There was a problem hiding this comment.
Only InvalidValueError for now but can be extended later
helene-nguyen
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
@flavienSindou Thank you for the hotfix that add changes to catch the error and allow to continue the process!
flavienSindou
deleted the
bug/3372-zvelo-connector-stops-working-if-data-is-invalid-or-incorrectly-formatted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
A Data Validation error raised while acquiring the data should be preferred to this hot fix directly inside the use case layer.
Notion investigation page: https://www.notion.so/filigran/Zvelo-Connector-stops-working-if-data-is-invalid-or-incorrectly-formatted-1928fce17f2a808fa051edf1224659ee