-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group IB] Update Group-IB connector #3411
Conversation
b513b96
to
11a05bf
Compare
@@ -63,23 +62,81 @@ def __init__(self): | |||
|
|||
def _load_config(self) -> dict: | |||
""" | |||
Load the configuration from the YAML file | |||
:return: Configuration dictionary | |||
Loads the configuration from `config.yml` or falls back to `config.yml.sample` if `config.yml` does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loads the configuration from `config.yml` or falls back to `config.yml.sample` if `config.yml` does not exist.
Thanks for your contribution! However, the changes related to the config.yml.sample fallback are not aligned with the project's convention. In this repository, we maintain consistency by only falling back to an empty dictionary ({}) when config.yml is missing. Making an exception for this case would introduce inconsistency across the project.
Would you mind adjusting the implementation to stick to this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @flavienSindou ,
Thanks for your review and your note about the configuration. Can you please tell me, do you mean to completely remove reading config.yml.sample from the project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your answer,
I meant the config.yml.sample
file should be an example file about how to create a config.yaml
file and should not be used into the code.
for file_path in [config_file_path, sample_config_file_path]: | ||
if file_path.is_file(): | ||
with open(file_path, "r", encoding="utf-8") as file: | ||
return yaml.load(file, Loader=yaml.FullLoader) | ||
|
||
return {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
Hello @flavienSindou , |
Proposed changes
Group-IB integration documentation update
Updating docker-compose and integration configuration
Related issues
#3405
Checklist
Further comments
--