Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectors] Fix valid_from date in some connectors + format files + correct relationships direction #3428

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Feb 14, 2025

Proposed changes

The valid_from and valid_until fields generated in Python within some connectors logic are not predictive, contrary to the expectations of OpenCTI platform's mechanisms. These fields, like IDs, must always be predictive. Otherwise, it is preferable to leave them empty, allowing the platform to populate them with its algorithms and rules.

Currently, using now for these fields when no data is provided disrupts the decay logic and other business processes implemented within OpenCTI. Moreover, this approach is redundant, as the platform already defaults to now when the fields are left empty.

  • Remove now date from valid_from attributes and replace by original and immutable date OR remove the field

Other changes

  • Fix format for Crowdsrtike IOC builder file
  • Fix format for Proofpoint TAP
  • Fix relationships: The relationship between observables and "threats" or "incidents" (threat actor, intrusion set, campaign, incident, etc.) should always be "Observable" => related-to => "Threat".

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Feb 14, 2025
@helene-nguyen helene-nguyen self-assigned this Feb 14, 2025
@helene-nguyen helene-nguyen changed the title [Connectors] Fix valid_from date in some connectors + format files [Connectors] Fix valid_from date in some connectors + format files + correct relationships Feb 14, 2025
@helene-nguyen helene-nguyen changed the title [Connectors] Fix valid_from date in some connectors + format files + correct relationships [Connectors] Fix valid_from date in some connectors + format files + correct relationships direction Feb 14, 2025
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SamuelHassine SamuelHassine force-pushed the master branch 2 times, most recently from b513b96 to 11a05bf Compare February 14, 2025 12:49
@helene-nguyen helene-nguyen merged commit 7502b02 into master Feb 17, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the issue/3245 branch February 17, 2025 06:53
maximus-debski pushed a commit to maximus-debski/connectors that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
2 participants