Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generic-connectors] Added generic connectors for IOC retrieval from simple line-based feeds #3440

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PaulBerra
Copy link

@PaulBerra PaulBerra commented Feb 18, 2025

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link
Author

@PaulBerra PaulBerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed assigned but unused var causing linter errors

@romain-filigran
Copy link
Member

Hello @PaulBerra and thank you for your contribution!

This connector suggestion appears to be very similar in functionality to our existing CSV Feed feature on the platform.
You can find the relevant documentation here: CSV Feed

Could you clarify the key differences between your connector proposal and this existing functionality?

@romain-filigran romain-filigran added the needs triage use to identify issue needing triage from Filigran Product team label Feb 18, 2025
@PaulBerra
Copy link
Author

PaulBerra commented Feb 18, 2025

Hello, the functionalities are very similar.
Your current CSV feed system is a HELL to manage and configure with mappers.
So I've made 4 connectors with a current use that are very simple and quick to set up for teams that don't necessarily have the time or resources to learn how to use opencti in detail, especially for such simple cases of data formatting.

The advantage of these connectors is that you simply have to name them in the Dockerfile, fill in the environment variable url and simply do a “docker-compose up” to get the connector.

I haven't invented any opencti functionality, I've simply created a more 'optimized' solution to a specific problem I've encountered (and that others will surely encounter) and I've proposed it as a commit for those who might find themselves in the same situation as me.

feel free to discard the pull request if you think it doesn't add any value

@helene-nguyen helene-nguyen changed the title [generic-connectors] Added generic connectors for IOC retrieval from … [generic-connectors] Added generic connectors for IOC retrieval from simple line-based feeds Feb 28, 2025
@helene-nguyen helene-nguyen added the community use to identify PR from community label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community needs triage use to identify issue needing triage from Filigran Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants