-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RST CLOUD] Connector Updates. New RST WHOIS API Connector #3443
base: master
Are you sure you want to change the base?
Conversation
…w RST WHOIS API connector
the formatting seems ok to me. please indicate what should we fix. locally gives |
@k1r10n Thank you for adding this ! Black and isort have made an update recently, could you please ensure that you have the last version of these dependencies ? |
@helene-nguyen thanks. Can you please suggest which versions should I use? tried these versions as well https://github.com/OpenCTI-Platform/connectors/blob/master/ci-requirements.txt |
It should be good with these versions, did you rebase master as well ? |
Maybe, to save time, just tell me which import lines to swap to meet the checks. I think that would be easier than setting up venv environments to find the right version. Thanks! |
hi @helene-nguyen, isort reverts the order to the one I have now (both isort == 6.0.0 and isort == 6.0.1). isort -v --profile black src/main.py
else-type place_module for os returned STDLIB
else-type place_module for os returned STDLIB |
Updates to RST Threat Feed, Report Hub, IoC Lookup, Noise Control, added a new RST WHOIS API connector
Proposed changes
Related issues
Checklist
Further comments