Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Taxii2] Handling Int in Config #3448

Merged
merged 3 commits into from
Feb 28, 2025
Merged

[Taxii2] Handling Int in Config #3448

merged 3 commits into from
Feb 28, 2025

Conversation

annoyingapt
Copy link
Contributor

@annoyingapt annoyingapt commented Feb 19, 2025 •
edited by helene-nguyen
Loading

Proposed changes

  • Defined variable type for integers which are pulled from config. In some customer environments these could be stored as strings, which will cause an error.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@helene-nguyen helene-nguyen self-assigned this Feb 28, 2025
@helene-nguyen helene-nguyen added community use to identify PR from community filigran verify Use to identify PR of connector Verified labels Feb 28, 2025
helene-nguyen
helene-nguyen approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annoyingapt Thank for your contribution, looks good to me :)

@helene-nguyen helene-nguyen linked an issue Feb 28, 2025 that may be closed by this pull request
[Taxii2] Handling Int in Config #3525
Closed
@helene-nguyen helene-nguyen merged commit b47f102 into OpenCTI-Platform:master Feb 28, 2025
4 checks passed
@helene-nguyen helene-nguyen linked an issue Feb 28, 2025 that may be closed by this pull request
OpenCTI TAXII2 Connector error OpenCTI-Platform/opencti#9949
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees

@helene-nguyen helene-nguyen

Labels
community use to identify PR from community filigran verify Use to identify PR of connector Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Taxii2] Handling Int in Config OpenCTI TAXII2 Connector error
2 participants
@annoyingapt @helene-nguyen