Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates] Update documentation + templates code #3450

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Feb 19, 2025

Proposed changes

  • Update documentation
    • Ensures that all contributors follow a standardized format, making it easier to understand and use the repository
    • Helps new contributors quickly grasp the structure, setup, and best practices
    • Keeps documentation up to date with new features, changes, or deprecated elements
  • Update templates code

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Feb 19, 2025
@helene-nguyen helene-nguyen self-assigned this Feb 19, 2025
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion but It looks good to me. Thank you for this update.

)
last_run_datetime = datetime.fromtimestamp(
current_timestamp, tz=timezone.utc
).strftime("%Y-%m-%d %H:%M:%S")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
).strftime("%Y-%m-%d %H:%M:%S")
).isoformat()

Comment on lines +195 to +197
info_msg = (
"Sending " + str(len(bundles_sent)) + " stix bundle(s) for worker import"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
info_msg = (
"Sending " + str(len(bundles_sent)) + " stix bundle(s) for worker import"
)
info_msg = (
f"Sending {len(bundles_sent)} stix bundle(s) for worker import"
)

@helene-nguyen helene-nguyen merged commit 4b258bb into master Feb 20, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the issue/3449-templates branch February 20, 2025 13:52
@helene-nguyen helene-nguyen linked an issue Feb 20, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Templates] Update documentation and templates
3 participants