Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All connectors] Remove remaining confidence_level in many connectors #3526

Merged
merged 4 commits into from
Feb 28, 2025
Merged

[All connectors] Remove remaining confidence_level in many connectors #3526

merged 4 commits into from
Feb 28, 2025

Conversation

Powlinett
Copy link
Member

Proposed changes

  • update templates
  • remove hardcoded confidence_level fields
  • remove self.helper.connect_confidence_level references
  • remove CONNECTOR_CONFIDENCE_LEVEL env var from config files and READMEs

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

⚠️ Some connectors are left unchanged as they need other fixes / refacto to remove confidence level safely

@Powlinett
[cisa-kev] remove confidence levels
59b4a71 
confidence levels are set on the user representing the connector
@Powlinett
[cve] remove confidence level
346005a 
confidence level is set on the user representing the connector
@Powlinett
[all] remove self.helper.connect_confidence_level references
f3bdb64 
self.helper.connect_confidence_level always returns None since it has been deprecated
@Powlinett
[all] remove confidence_level from config files / documentation
3e298c7
@Powlinett Powlinett self-assigned this Feb 28, 2025
@Powlinett Powlinett added the filigran team use to identify PR from the Filigran team label Feb 28, 2025
@helene-nguyen helene-nguyen changed the title Remove remaining confidence_level in many connectors [All connectors] Remove remaining confidence_level in many connectors Feb 28, 2025
@Powlinett Powlinett mentioned this pull request Feb 28, 2025
Closed
helene-nguyen
helene-nguyen approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Powlinett for this HUGE work !

Everything look good to me :)

@ParamConstructor ParamConstructor mentioned this pull request Feb 28, 2025
Open
6 tasks
@Powlinett Powlinett merged commit 04a69fb into master Feb 28, 2025
4 checks passed
@Powlinett Powlinett deleted the issue/3315-confidence-level branch February 28, 2025 19:55
This was linked to issues Mar 4, 2025
CISA KEV connector doesn't update objects #3315
Closed
[All connectors] Update all connectors to be aligned with confidence level changes #1816
Open
This was referenced Mar 5, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen approved these changes

Assignees

@Powlinett Powlinett

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
2 participants
@Powlinett @helene-nguyen