Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tenable Vuln Management] fix: Connector config loader only works with config.yaml #3541

Merged
merged 2 commits into from
Mar 4, 2025
Merged

[Tenable Vuln Management] fix: Connector config loader only works with config.yaml #3541

merged 2 commits into from
Mar 4, 2025

Conversation

flavienSindou
Copy link
Contributor

Proposed changes

  • Ensure connector key exists before setting connector.type variable

This fixes bug introduced with #3463

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Related Investigation Notion Page : https://www.notion.so/filigran/tenable-vuln-management-config-loader-is-broken-1ab8fce17f2a806a9c8ac535a350d39b?pvs=4

@flavienSindou flavienSindou linked an issue Mar 3, 2025 that may be closed by this pull request
[tenable-vuln-management] Fails to start with KeyError: 'connector' #3518
Closed
@flavienSindou flavienSindou changed the title fix: ensure connector key does exist when hard coding connector type [Tenable Vuln Management] fix: Connector config loader only works with config.yaml Mar 3, 2025
@flavienSindou flavienSindou self-assigned this Mar 3, 2025
@flavienSindou flavienSindou added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team critical use to identify critical bug to fix ASAP labels Mar 3, 2025
@flavienSindou flavienSindou added this to the PRs backlog milestone Mar 3, 2025
Powlinett
Powlinett approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succeed to start connector with docker ✅

@flavienSindou flavienSindou merged commit c50b57d into master Mar 4, 2025
2 of 4 checks passed
@flavienSindou flavienSindou deleted the bug/3518-tenable-vuln-management-fails-to-start-with-keyerror-connector branch March 4, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

@Powlinett Powlinett Powlinett approved these changes

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees

@flavienSindou flavienSindou

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
PRs backlog
Development

Successfully merging this pull request may close these issues.

[tenable-vuln-management] Fails to start with KeyError: 'connector'
3 participants
@flavienSindou @Megafredo @Powlinett