[Tenable Vuln Management] fix: last_scan_target attribute inconsistent presence in API response should be handled gracefully #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should be handled gracefully
flavienSindou
requested review from
Megafredo,
pdamoune,
Powlinett and
helene-nguyen
flavienSindou
added
bug
Powlinett
previously requested changes
Mar 3, 2025
There was a problem hiding this comment.
I tried to remove last_scan_target from assets in tenable_api_response.json and I got this error:
with pytest.warns(ValidationWarning):
> _ = VulnerabilityFinding.model_validate(tenable_api_response_1_report)
E pydantic_core._pydantic_core.ValidationError: 1 validation error for VulnerabilityFinding
E asset.last_scan_target
E Field required [type=missing, input_value={'device_type': 'hypervis...00000', 'tracked': True}, input_type=dict]
E For further information visit https://errors.pydantic.dev/2.10/v/missing
tests\test_models\test_tenable.py:76: ValidationError
I think it's missing a default value, see my comment.
| @@ -286,7 +286,7 @@ class Asset(FrozenBaseModelWithWarnedExtra): | |||
| ..., description="The ID of the network the asset belongs to." | |||
| ) | |||
| tracked: bool = Field(..., description="Indicates if the asset is being tracked.") | |||
| last_scan_target: str = Field( | |||
| last_scan_target: Optional[str] = Field( | |||
| ..., | |||
There was a problem hiding this comment.
Default should be set to None, no?
There was a problem hiding this comment.
You are right ! Thank you for your remark !
Powlinett
approved these changes
Mar 4, 2025
flavienSindou
deleted the
bug/3542-tenable-vuln-management-last_scan_target-attribute-inconsistent-presence-in-api-response-should-be-handled-gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
https://www.notion.so/filigran/Tenable-Vuln-Management-Tenable-Breaking-API-Changes-1a48fce17f2a807e8275fd416f7df756?pvs=4#1ab8fce17f2a8004b503fb022ed808db