Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo GraphQL Playground/v3 Deprecation #7363

Closed
x86NOP opened this issue Jun 12, 2024 · 6 comments · Fixed by #9328
Closed

Apollo GraphQL Playground/v3 Deprecation #7363

x86NOP opened this issue Jun 12, 2024 · 6 comments · Fixed by #9328
Assignees
Labels
dependencies use for pull requests that update a dependency file solved use to identify issue that has been solved (must be linked to the solving PR) technical improvement Technical refactor or improvement is needed
Milestone

Comments

@x86NOP
Copy link

x86NOP commented Jun 12, 2024

Description

The Apollo GraphQL Playground is both still present and enabled in the OpenCTI images built/distributed as of v6.1.10. Playground has been EOL since 2022-12-31 (https://www.apollographql.com/docs/apollo-server/v2/testing/graphql-playground/) and its existence in current builds appears to just be an overlooked artifact from the upgrade from Apollo 2.x to 3.x here in the past.

Furthermore, it should be noted that Apollo 3.x is EOL as of 2024-10-22 requiring an upgrade to Apollo 4.x before that date (https://www.apollographql.com/docs/apollo-server/migration).

Environment

  1. Ubuntu 22.04.4 LTS
  2. OpenCTI 6.1.10
  3. Frontend
  4. Other environment details:

Reproducible Steps

In a browser just visit https[:]//youropencti[.]url /graphql

Expected Output

Having Playground available in production was generally considered a security misconfiguration (and risk) in Apollo 2.x, and there is no reason to have it present in any environment in Apollo 3.x. Given its history including high severity XSS, it should be removed completely from released builds/images.

Actual Output

Playground is still present in distributed builds/images, providing no benefit and introducing potential risk of exploitation.

Additional information

You can close this related 2.5 year old issue at the same time.
#1835

Screenshots (optional)

image

@x86NOP x86NOP added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jun 12, 2024
@Kedae
Copy link
Member

Kedae commented Jun 13, 2024

We are currently migrating towards V4 for Apollo server. We will look into it.

@Kedae Kedae added dependencies use for pull requests that update a dependency file and removed bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jun 13, 2024
@RegturH
Copy link

RegturH commented Oct 16, 2024

any update on this? this is also the case on the demo instance: https://demo.opencti.io/graphql

@Archidoit
Copy link
Member

This upgrade will be planned in the coming months I think. @nino-filigran ?

@SamuelHassine
Copy link
Member

SamuelHassine commented Oct 17, 2024

I agree this is starting to be really painful for our technical users @nino-filigran @romain-filigran .

@nino-filigran
Copy link

Yes, I'll update the ticket with the according milestone as son as I can.

@labo-flg labo-flg added the technical improvement Technical refactor or improvement is needed label Oct 30, 2024
Archidoit added a commit that referenced this issue Dec 23, 2024
Archidoit added a commit that referenced this issue Dec 23, 2024
@aHenryJard
Copy link
Member

It seems that apollo sandbox cannot be air gapped, since it's a strong requirement for OpenCTI to work in an air gapped environnement, we looking to replace appollo playground by graphiql instead of apollo sandbox.

@Archidoit Archidoit added this to the Release 6.5.0 milestone Jan 9, 2025
Archidoit added a commit that referenced this issue Jan 16, 2025
@Archidoit Archidoit added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jan 16, 2025
@SamuelHassine SamuelHassine reopened this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies use for pull requests that update a dependency file solved use to identify issue that has been solved (must be linked to the solving PR) technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants