Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ingestion: manage error on file issue and allow ingestion of elements with missing files #9371

Closed
aHenryJard opened this issue Dec 17, 2024 · 1 comment · Fixed by #9394
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@aHenryJard
Copy link
Member

Description

When there is a missing file or a file that is not allowed to user for any reason (usually an HTTP 503 in logs), ingestion in sync manager of data is stopped.
Would be great to try/catch the error on file get and ingest element data.

Need to discuss if we log a warning or error in case of missed files.

Implementation that requires a try/catch is around here:

const response = await httpClient.get(`${httpBase(uri)}${fileUri.substring(fileUri.indexOf('storage/get'))}`);

Environment

  1. OS (where OpenCTI server runs): { e.g. Mac OS 10, Windows 10, Ubuntu 16.4, etc. }
  2. OpenCTI version: { e.g. OpenCTI 1.0.2 }
  3. OpenCTI client: { e.g. frontend or python }
  4. Other environment details:

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. { e.g. Run ... }
  2. { e.g. Click ... }
  3. { e.g. Error ... }

Expected Output

Actual Output

Additional information

Screenshots (optional)

@aHenryJard aHenryJard added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 17, 2024
@romain-filigran romain-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Dec 17, 2024
@romain-filigran romain-filigran added this to the Bugs backlog milestone Dec 17, 2024
@richard-julien
Copy link
Member

Lets log a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
4 participants