Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deletion of element with hundreds of thousands relationships #9923

Closed
richard-julien opened this issue Feb 10, 2025 · 0 comments · Fixed by #9924
Closed

Improve deletion of element with hundreds of thousands relationships #9923

richard-julien opened this issue Feb 10, 2025 · 0 comments · Fixed by #9924
Assignees
@richard-julien
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.5.2

Comments

@richard-julien
Copy link
Member

richard-julien commented Feb 10, 2025 •
edited
Loading

Use case

Improve deletion of element with hundreds of thousands relationships.
In some massive deletions, the Ramda merge all can fail for RangeError: Maximum call stack size exceeded

What to do

  • Change the implementation to prevent mergeAll usage that use _curry internally that destructure elements
  • Add setImmediate splitter to improve event loop management
@richard-julien richard-julien added the bug use for describing something not working as expected label Feb 10, 2025
@richard-julien richard-julien self-assigned this Feb 10, 2025
richard-julien added a commit that referenced this issue Feb 10, 2025
@richard-julien
[backend] Improve deletion of element with hundreds of thousands rela…
da6bd6b 
…tionships (#9923)
@richard-julien richard-julien mentioned this issue Feb 10, 2025
Merged
@richard-julien richard-julien added this to the Release 6.5.2 milestone Feb 11, 2025
@richard-julien richard-julien linked a pull request Feb 11, 2025 that will close this issue
[backend] Improve deletion of element with hundreds of thousands relationships (#9923) #9924
Merged
richard-julien added a commit that referenced this issue Feb 13, 2025
@richard-julien
[backend] Improve deletion of element with hundreds of thousands rela…
fefb894 
…tionships (#9923)
@richard-julien richard-julien added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-julien richard-julien

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.5.2
1 participant
@richard-julien