-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] Fix button size in cards views (#9723) #10000
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10000 +/- ##
=======================================
Coverage 64.32% 64.32%
=======================================
Files 656 656
Lines 63037 63038 +1
Branches 6992 6993 +1
=======================================
+ Hits 40546 40552 +6
+ Misses 22491 22486 -5 ☔ View full report in Codecov by Sentry. |
<Select | ||
name="sort-by" | ||
value={sortBy} | ||
<div className={classes.sortFieldContainer}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand how this fixes the button size ?
When I test, the button height is still different between the two modes (38px and a bit less).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the alignItems: 'center' makes it possible to readjust the buttons a little. Before they were 36px high, now they're 37.6979px. Not identical, but close enough to the 38px of the line view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, all good to me.
Proposed changes
Related issues