Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix button size in cards views (#9723) #10000

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

Proposed changes

  • Fix button size in cards views
  • Fix Line Button's color in malware view

Related issues

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX added the filigran team use to identify PR from the Filigran team label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.32%. Comparing base (c7a2358) to head (a9f2083).
Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10000   +/-   ##
=======================================
  Coverage   64.32%   64.32%           
=======================================
  Files         656      656           
  Lines       63037    63038    +1     
  Branches     6992     6993    +1     
=======================================
+ Hits        40546    40552    +6     
+ Misses      22491    22486    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review February 18, 2025 10:50
@Archidoit
Copy link
Member

The buttons are changing place when we switch between card view and list view in Arsenal > Malware
image

The behavior is ok in Threat Actor Groups
image

@Gwendoline-FAVRE-FELIX
Copy link
Member Author

Gwendoline-FAVRE-FELIX commented Feb 19, 2025

The buttons are changing place when we switch between card view and list view in Arsenal > Malware image

The behavior is ok in Threat Actor Groups image

This is another existing bug caused by the scroll bar moving across lines.

<Select
name="sort-by"
value={sortBy}
<div className={classes.sortFieldContainer}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand how this fixes the button size ?
When I test, the button height is still different between the two modes (38px and a bit less).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the alignItems: 'center' makes it possible to readjust the buttons a little. Before they were 36px high, now they're 37.6979px. Not identical, but close enough to the 38px of the line view.

Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, all good to me.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 830ef4a into master Feb 26, 2025
9 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/9723 branch February 26, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants