Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Only accessible markings visible in filters (#10006) #10010

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Archidoit
Copy link
Member

Proposed changes

In 'markings' filter, the user should only be able to see the markings he has access to

Related issues

#10006

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Feb 19, 2025
@Archidoit Archidoit self-assigned this Feb 19, 2025
@Archidoit Archidoit linked an issue Feb 19, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.32%. Comparing base (0d61f48) to head (15b85ba).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10010   +/-   ##
=======================================
  Coverage   64.31%   64.32%           
=======================================
  Files         656      656           
  Lines       63037    63037           
  Branches     6985     6989    +4     
=======================================
+ Hits        40544    40546    +2     
+ Misses      22493    22491    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@Archidoit Archidoit merged commit 5d1466a into master Feb 24, 2025
9 checks passed
@Archidoit Archidoit deleted the issue/10006 branch February 24, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marking not accessible which are visible in the filters
2 participants