Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Mandatory file for Artifact creation (#8794) #10075

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

marieflorescontact
Copy link
Member

@marieflorescontact marieflorescontact commented Feb 25, 2025

Proposed changes

  • add file in Yup schema validation and directly use <CustomFileUploader> component with formik errors as prop

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@marieflorescontact marieflorescontact self-assigned this Feb 25, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (e1fee54) to head (08b492b).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10075   +/-   ##
=======================================
  Coverage   64.30%   64.30%           
=======================================
  Files         656      656           
  Lines       63046    63046           
  Branches     6988     6986    -2     
=======================================
+ Hits        40541    40544    +3     
+ Misses      22505    22502    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact marked this pull request as ready for review February 25, 2025 14:22
@marieflorescontact marieflorescontact merged commit 467e3e6 into master Feb 26, 2025
9 checks passed
@marieflorescontact marieflorescontact deleted the issue/8794 branch February 26, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior on OpenCTI regarding artifact creation
2 participants