Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Inconsistancy of empty fields in Threat Actor Individual overview (#9818) #10106

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • add fieldOrEmpty component

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Feb 27, 2025
@SarahBocognano SarahBocognano self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.31%. Comparing base (dc9709a) to head (5179c0c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10106      +/-   ##
==========================================
- Coverage   64.31%   64.31%   -0.01%     
==========================================
  Files         656      656              
  Lines       63047    63047              
  Branches     6990     6987       -3     
==========================================
- Hits        40551    40549       -2     
- Misses      22496    22498       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

Archidoit commented Feb 27, 2025

Ok for threat actor individuals

Can you also fix this for threat actor groups and other entities with 'primary motivation' (like intrusion set)?

image

image

@SarahBocognano
Copy link
Member Author

Of course ! Thanks for pointing them :)

@Archidoit
Copy link
Member

missing '-' for secondary motivations in Intrusion Sets
image

@Archidoit
Copy link
Member

in intrusion sets, originates from is badly formatted if empty :
image

see model:
image

@Archidoit
Copy link
Member

Too much margin before the '-' of located_at in threat actor group overview :
image

Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tested ok

@SarahBocognano SarahBocognano merged commit 5dd1b6c into master Mar 3, 2025
9 checks passed
@SarahBocognano SarahBocognano deleted the issue/9818 branch March 3, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants