Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Bad margin/padding on some pages with an information section (#10053) #10140

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Remove "noMargin" props in breadcrumbs
  • Add a marginBottom to alert component

Related issues

@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Mar 4, 2025
@SarahBocognano SarahBocognano self-assigned this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.31%. Comparing base (fbfcc97) to head (29c180c).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10140   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files         656      656           
  Lines       63048    63048           
  Branches     6990     6993    +3     
=======================================
  Hits        40552    40552           
  Misses      22496    22496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano merged commit a322905 into master Mar 5, 2025
9 checks passed
@SarahBocognano SarahBocognano deleted the issue/10053 branch March 5, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants