Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Update description for placeholders #10146

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Mar 5, 2025

Proposed changes

  • Update description for placeholders.
  • Test in staging obas: link
    image
    image

Related issues

  • Linked to task in obas Nro 2608

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Mar 5, 2025
@savacano28 savacano28 self-assigned this Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (9542e94) to head (7b6e0de).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...form/opencti-graphql/src/modules/xtm/xtm-domain.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10146   +/-   ##
=======================================
  Coverage   64.30%   64.31%           
=======================================
  Files         656      656           
  Lines       63048    63048           
  Branches     6986     6989    +3     
=======================================
+ Hits        40545    40547    +2     
+ Misses      22503    22501    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review March 5, 2025 10:49
@savacano28 savacano28 linked an issue Mar 5, 2025 that may be closed by this pull request
@savacano28 savacano28 merged commit 0a077fe into master Mar 5, 2025
9 checks passed
@savacano28 savacano28 deleted the bugfix/obas-2608 branch March 5, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change wording of the placeholder
2 participants