Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix filters edition after NLQ search & check date filters validity (#9751) #10177

Open
wants to merge 2 commits into
base: release/6.6.0
Choose a base branch
from

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Mar 7, 2025

Proposed changes

Fix filters edition after NLQ search (frontend)

  • Be able to modify the filters after a NLQ search
  • The entities list should be updated according to these filters changes

Check date filters values validity (backend)

  • check filters values validity for date filters: values should be absolute date or relative dates in date math format
  • backend tests
    --> This avoids NLQ first model crash with queries like : 'list the 10 most recent reports'

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Mar 7, 2025
@Archidoit Archidoit self-assigned this Mar 7, 2025
@Archidoit Archidoit changed the title [frontend] Fix filters edition after NLQ search (#9751) [frontend] Fix filters edition and display after NLQ search (#9751) Mar 7, 2025
@Archidoit Archidoit changed the title [frontend] Fix filters edition and display after NLQ search (#9751) [frontend] Fix filters edition after NLQ search & check date filters validity (#9751) Mar 7, 2025
@Archidoit Archidoit requested a review from aHenryJard March 7, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant