Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Titles to Functional Component Pages Only #7753

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Updated Titles to Functional Component Pages Only #7753

merged 1 commit into from
Dec 10, 2024

Conversation

dotdev8
Copy link
Contributor

@dotdev8 dotdev8 commented Jul 18, 2024

Proposed changes

  • Updated Titles to Functional Component Pages

Related issues

  • Adding Titles to the class component pages causes the page to throw an error.
  • On pages where class components were converted to functional components, the title disappears on refresh. Assuming this may have something to do with the saveView() function.

Checklist

  • [ x] I consider the submitted work as finished
  • [ x] I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

The pages described in the Related Issues above have not been altered. Only functional component pages where the title persists have been updated. The other pages will be updated in a later PR once the issues have been identified and resolved.

@SarahBocognano SarahBocognano added the community use to identify PR from community label Jul 23, 2024
@dotdev8 dotdev8 force-pushed the new_title_lang branch 2 times, most recently from b785405 to cfeb7d3 Compare July 23, 2024 15:01
@dotdev8 dotdev8 force-pushed the new_title_lang branch 2 times, most recently from 6eea9f1 to f49b8c8 Compare August 21, 2024 18:24
@VerboseCat VerboseCat force-pushed the new_title_lang branch 5 times, most recently from cf2f26c to e8d2599 Compare September 3, 2024 19:31
VerboseCat added a commit to fbicyber/opencti__opencti that referenced this pull request Sep 3, 2024
@VerboseCat
Remove changes established in PR OpenCTI-Platform#7753
d168532
VerboseCat added a commit to fbicyber/opencti__opencti that referenced this pull request Sep 4, 2024
@VerboseCat
Remove changes established in PR OpenCTI-Platform#7753
7740ce0
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Sep 4, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
a5982a6 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.20%. Comparing base (3484b43) to head (bbd5538).
Report is 1 commits behind head on release/6.5.0.

Additional details and impacted files 
@@                Coverage Diff                @@
##           release/6.5.0    #7753      +/-   ##
=================================================
- Coverage          65.21%   65.20%   -0.02%     
=================================================
  Files                626      626              
  Lines              59886    59886              
  Branches            6688     6685       -3     
=================================================
- Hits               39053    39047       -6     
- Misses             20833    20839       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VerboseCat VerboseCat force-pushed the new_title_lang branch 4 times, most recently from af7523e to d51ab71 Compare September 5, 2024 12:54
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Sep 5, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
7340c8d 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753
@VerboseCat VerboseCat force-pushed the new_title_lang branch 2 times, most recently from e71d6c3 to a2c8237 Compare September 5, 2024 13:25
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Sep 6, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
cda8fe9 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;
@VerboseCat
Copy link
Contributor

VerboseCat commented Sep 6, 2024 •
edited
Loading

This PR has a known issue. Every time a page renders, both the the custom page title setting function useConnectedDocumentModifier.setTitle and the default page title setting function useDocumentLangModifier run and set the title. In some instances, the default page title is set after the custom page title is set. This results in the default page title being displayed. I was unable to find a cause or pattern for which components exhibit this bug.

The following components from this PR are impacted:

  • Data / Ingestion / OpenCTI Steams (data/Sync.jsx)
  • Data / Ingestion / TAXII Feeds (data/IngestionTaxiis.jsx)
  • Data / Ingestion / RSS Feeds (data/IngestionRss.jsx)
  • Data / Processing / Tasks (data/Tasks.jsx)
  • Data / Data sharing / CSV feeds (data/Feed.tsx)
  • Data / Data sharing / TAXII collections (data/Taxii.tsx)
  • Settings / Parameters (settings/Settings.jsx)
  • Settings / Security / Users (settings/Users.jsx)
  • Settings / Taxonomies / Vocabularies (settings/Vocabularies.tsx)

@VerboseCat VerboseCat force-pushed the new_title_lang branch 3 times, most recently from 732b9ce to aab7e1e Compare September 10, 2024 12:50
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Sep 10, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
a16d044 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;
@VerboseCat VerboseCat mentioned this pull request Sep 10, 2024
Merged
5 tasks
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Oct 30, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
4edd436 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
@labo-flg labo-flg changed the base branch from master to release/6.4.0 October 30, 2024 12:40
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Oct 30, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
f0603a1 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 4, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
517c8d0 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 12, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
302b0a3 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 14, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
5bccf3c 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
@SarahBocognano SarahBocognano self-assigned this Nov 14, 2024
@SarahBocognano
Copy link
Member

SarahBocognano commented Nov 15, 2024 •
edited
Loading

I approved this PR. Just need to resolve the conflit before merging :)

VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 15, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
1ffd14a 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 19, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
125ffec 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 21, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
3ad6d7f 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
@VerboseCat
Copy link
Contributor

@SarahBocognano Thank you! Could you please change the release branch to release/6.5.0? I do not have the permissions.

VerboseCat pushed a commit to fbicyber/opencti__opencti that referenced this pull request Nov 26, 2024
@Bonsai8863 @VerboseCat
[frontend] Add page titles to Settings pages
6a234ba 
Revert WIP conversion of Sectors

test commit

Fix paginationOptions issue for Groups, KillChainPhases, Roles

Fix MarkingDefinitions, update KillChainPhases to reflect master

Remove changes established in PR OpenCTI-Platform#7753

Add Malwares.tsx to removed changes

Post-rebase cleanup

Remove changes from PR 7753

Remove outdated changes to KillChainPhases

Fix translations

Align GroupLine design with master

Fix typing on GroupLines;

Remove variant from breadcrumbs
@SarahBocognano SarahBocognano changed the base branch from release/6.4.0 to release/6.5.0 November 27, 2024 16:22
@Archidoit Archidoit changed the base branch from release/6.5.0 to master December 9, 2024 13:31
@Archidoit Archidoit changed the base branch from master to release/6.5.0 December 9, 2024 13:31
@Bonsai8863 @VerboseCat
[Frontend] Add titles on functional component pages
bbd5538 
WIP - Adding Titles to pages

WIP - Updating Titles

WIP - Updating Titles for Functional Components only.

Updated Titles. Some class component pages have not been updated.

Revert "Updated Titles. Some class component pages have not been updated."

This reverts commit babb1cd.

Updated Titles. Some class component pages have not been updated.

Resolving Merge Conflicts

[frontend] Replaced Creation Floating Action Buttons for Cases

[frontend] Replaced Creation Floating Action Buttons for Observations

Fixed minor errors

Fixed duplicate issue.

Add translations and linting

Fix import issue from merge

Minor cleanup

Test commit

Formatting change

Add space to root again?

Add settings pages that are already functional

Add killChainPhases

Update translations

Add Narratives title

Translate narratives

Add data components

Remove duplicate Data titles (pt 2)

Add translations

Fix case on Taxii.tsx

Update translations
@VerboseCat
Copy link
Contributor

@Archidoit the merge conflict is resolved and this PR is ready for merge.

@Archidoit Archidoit merged commit e725d6e into OpenCTI-Platform:release/6.5.0 Dec 10, 2024
4 checks passed
@Archidoit
Copy link
Member

Thanks for your contribution :) The branch has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahBocognano SarahBocognano SarahBocognano approved these changes

Assignees

@SarahBocognano SarahBocognano

Labels
community use to identify PR from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dotdev8 @VerboseCat @SarahBocognano @Archidoit @Bonsai8863