Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Popover arsenal menu support for FAB_REPLACEMENT feature flag #8999

Conversation

Bonsai8863
Copy link
Contributor

Proposed changes

These changes apply to the Arsenal menu items in support of the popover removal as part of the FAB_REPLACEMENT feature flag.

  • Remove the ... popover icon.
  • Move the "Delete" from this popover into the Drawer for the item, have the button be on the bottom left of the drawer in red
  • Float the Enrich option to the top row and use the default cloud enrichment icon

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.20%. Comparing base (e725d6e) to head (1673c9f).
Report is 5 commits behind head on release/6.5.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #8999      +/-   ##
=================================================
- Coverage          65.21%   65.20%   -0.01%     
=================================================
  Files                626      626              
  Lines              59886    59892       +6     
  Branches            6688     6689       +1     
=================================================
+ Hits               39053    39055       +2     
- Misses             20833    20837       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact self-assigned this Nov 18, 2024
@marieflorescontact marieflorescontact added the community use to identify PR from community label Nov 18, 2024
@marieflorescontact marieflorescontact changed the base branch from release/6.4.0 to release/6.5.0 December 3, 2024 10:54
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionnaly tested 👌

@daimyo007 daimyo007 force-pushed the popover-removal-arsenal branch from bbe2e6f to 243431b Compare December 3, 2024 14:55
@marieflorescontact
Copy link
Member

The enrichment button is missing for Malwares/Tools/Vulnerabilities/Channels

@ParamConstructor
Copy link
Contributor

The enrichment button is missing for Malwares/Tools/Vulnerabilities/Channels

@marieflorescontact - This should be correct in this latest commit and adds the "enrich" icon/button when FAB feature is active.

Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok 🙂

@marieflorescontact marieflorescontact merged commit 6d9dbbd into OpenCTI-Platform:release/6.5.0 Dec 11, 2024
4 checks passed
@marieflorescontact marieflorescontact deleted the popover-removal-arsenal branch December 11, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants