Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Change marking values order: TLP:AMBER+STRICT to be hierarchically greater than TLP:AMBER (#9450) #9515

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Jan 7, 2025

Proposed changes

  • change marking values order during database initialization

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.15%. Comparing base (5526f43) to head (45bc430).
Report is 342 commits behind head on master.

Files with missing lines Patch % Lines
...pencti-graphql/src/database/data-initialization.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9515   +/-   ##
=======================================
  Coverage   65.14%   65.15%           
=======================================
  Files         628      628           
  Lines       60037    60037           
  Branches     6692     6693    +1     
=======================================
+ Hits        39112    39117    +5     
+ Misses      20925    20920    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano
Copy link
Member

I tested it, and everything works fine. I have a question though : Don't we need to do a migration here ?

@aHenryJard
Copy link
Member

I tested it, and everything works fine. I have a question though : Don't we need to do a migration here ?

No because it's very hard to guess what people have done in their platform since it's hightly customizable.

@aHenryJard
Copy link
Member

On my side I wonder if we shouldn't set PAP:RED to 5 too, when started a new platform here is what we have:

image

@CelineSebe
Copy link
Member Author

CelineSebe commented Feb 18, 2025

On my side I wonder if we shouldn't set PAP:RED to 5 too, when started a new platform here is what we have:

Is it OK not to have a rank 4 for the PAPs?

@CelineSebe CelineSebe merged commit b6f8b08 into master Feb 19, 2025
9 checks passed
@CelineSebe CelineSebe deleted the issue/9450 branch February 19, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marking values order: change TLP:AMBER+STRICT to be hierarchically greater than TLP:AMBER
3 participants