[frontend] Add a new relationship views in entities having an Attack Pattern Knowledge view (#8835) #9623

CelineSebe · 2025-01-16T16:06:32Z

Proposed changes

add relationship view button
add dataTable view for the relationships
add generic component to display the relationship

Related issues

Add a view in entity/knowledge/attack pattern representing the relation #8835

Checklist

I consider the submitted work as finished
I tested the code for its functionality
I wrote test cases for the relevant uses case (coverage and e2e)
I added/update the relevant documentation (either on github or on notion)
Where necessary I refactored code to improve the overall quality

Further comments

codecov · 2025-01-22T16:39:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (6485014) to head (b26e093).
Report is 9 commits behind head on release/6.5.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release/6.5.0    #9623      +/-   ##
=================================================
+ Coverage          64.29%   64.33%   +0.04%     
=================================================
  Files                653      653              
  Lines              62473    62475       +2     
  Branches            6920     6923       +3     
=================================================
+ Hits               40166    40195      +29     
+ Misses             22307    22280      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SouadHadjiat · 2025-01-24T09:03:28Z

...pencti-front/src/private/components/common/stix_core_relationships/StixCoreRelationships.tsx

+        preloadedPaginationProps={preloadedPaginationProps}
+        exportContext={{ entity_type: 'Attack-Pattern' }}
+        additionalHeaderButtons={[
+          (<ToggleButton key="matrix" value="matrix" aria-label="matrix">


would be nice if we could extract this list of buttons to avoid duplication with StixDomainObjectAttackPatternsKillChainMatrixInLine

marieflorescontact

Locally tested:

There is a scroll bar when list is empty:
Need to full refresh to see in the list newly created relationship
Sorting by type/creators/authors makes the platform crash

CelineSebe · 2025-01-27T10:15:56Z

There is a scroll bar when list is empty:

I don't reproduce this issue on my side, but it is linked to the datatable.

Are you in full screen? You may need to reset the columns.

I'll look into the other issues. thanks !

marieflorescontact · 2025-01-27T10:14:21Z

...pencti-front/src/private/components/common/stix_core_relationships/StixCoreRelationships.tsx

+    predefinedFilters.push({ key: 'elementWithTargetTypes', values: targetTypes });
+  } else if (direction === 'toEntity') {
+    predefinedFilters.push({ key: 'toId', values: [entityId] });
+    // if (role) predefinedFilters.push({ key: 'toRole', values: [role] });


Did you forget comments (line 302, 306)

SouadHadjiat

Select all relationships targets all entities in the platform, there should be filters

marieflorescontact

functionally tested ok 👌

marieflorescontact · 2025-01-29T16:25:06Z

opencti-platform/opencti-front/src/utils/hooks/useQueryLoading.ts

@@ -21,4 +22,22 @@ const useQueryLoading = <T extends OperationType>(
  return queryRef;
 };

+export const useQueryLoadingWithLoadQuery = <T extends OperationType>(
+  query: GraphQLTaggedNode | PreloadableConcreteRequest<T>,


Do we really need to create a new method here, as the code is exactly the same as in useQueryLoading except for the return ?

it's not exactly the same. We have returned loadQuery in addition to queryRef.

yes, the return is different, loadQuery is returned in useQueryLoadingWithLoadQuery but except that the method is exectly the same. I was wondering if we really need to have 2 methods

CelineSebe self-assigned this Jan 16, 2025

CelineSebe changed the base branch from master to release/6.5.0 January 16, 2025 16:07

CelineSebe changed the title ~~[frontend] Add a new relationship views in entitys having an Attack Pattern Knwoledge view (#8835)~~ [frontend] Add a new relationship views in entities having an Attack Pattern Knwoledge view (#8835) Jan 16, 2025

labo-flg force-pushed the release/6.5.0 branch 5 times, most recently from 9535c45 to 8574b42 Compare January 17, 2025 16:11

labo-flg added the filigran team use to identify PR from the Filigran team label Jan 20, 2025

CelineSebe force-pushed the issue/8835 branch from f04aaec to 8d1ee2f Compare January 20, 2025 13:56

CelineSebe force-pushed the issue/8835 branch 3 times, most recently from 1b33fee to a58bb96 Compare January 23, 2025 14:16

CelineSebe marked this pull request as ready for review January 23, 2025 15:35

CelineSebe linked an issue Jan 23, 2025 that may be closed by this pull request

Add a view in entity/knowledge/attack pattern representing the relation #8835

Closed

delemaf self-requested a review January 23, 2025 15:42

SouadHadjiat reviewed Jan 24, 2025

View reviewed changes

SamuelHassine force-pushed the release/6.5.0 branch from 8ac2996 to fcf2a9c Compare January 27, 2025 09:33

marieflorescontact self-requested a review January 27, 2025 09:41

marieflorescontact reviewed Jan 27, 2025

View reviewed changes

SouadHadjiat requested changes Jan 28, 2025

View reviewed changes

SouadHadjiat changed the title ~~[frontend] Add a new relationship views in entities having an Attack Pattern Knwoledge view (#8835)~~ [frontend] Add a new relationship views in entities having an Attack Pattern Knowledge view (#8835) Jan 28, 2025

CelineSebe added 5 commits January 29, 2025 10:18

[frontend] relationships view button

9f2e9e4

[frontend] investigation

2e0158d

[frontend] investigation relationships view displayed

3d02704

[frontend] relationships view displays

4ac9c89

[frontend] reverse ThreatActorGroupKnowledge

effd9f3

CelineSebe and others added 14 commits January 29, 2025 10:18

[frontend] wip

d6a8074

[frontend] fix front

67828f7

[frontend] new query

8cd591a

[frontend] indentation

e407304

[frontend] Fix relationship creation

4d52e29

[frontend] fix column

3ea361b

[frontend] clean up

78a4dcd

[frontend] fix storage key & pagination

40c2f90

fix URI & name

54d068a

[frontend] matrix inline

37fb015

fix filters

4134aee

[frontend] refactor view buttons

8d5b0ae

[frontend] revert storagekey matrix inline

bc6553f

[frontend] Fixes

8c5bd5f

CelineSebe force-pushed the issue/8835 branch from 1e12ece to 8c5bd5f Compare January 29, 2025 09:33

[frontend] fix deepscan

7e439ca

marieflorescontact self-requested a review January 29, 2025 15:55

marieflorescontact reviewed Jan 29, 2025

View reviewed changes

last fixes

b26e093

marieflorescontact reviewed Jan 29, 2025

View reviewed changes

SouadHadjiat self-requested a review January 29, 2025 16:52

SouadHadjiat approved these changes Jan 29, 2025

View reviewed changes

delemaf removed their request for review January 30, 2025 08:22

CelineSebe merged commit cbb6dd7 into release/6.5.0 Jan 30, 2025
5 checks passed

CelineSebe deleted the issue/8835 branch January 30, 2025 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[frontend] Add a new relationship views in entities having an Attack Pattern Knowledge view (#8835) #9623

[frontend] Add a new relationship views in entities having an Attack Pattern Knowledge view (#8835) #9623

CelineSebe commented Jan 16, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

SouadHadjiat Jan 24, 2025

marieflorescontact left a comment •

edited

Loading

CelineSebe commented Jan 27, 2025

marieflorescontact Jan 27, 2025

SouadHadjiat left a comment

marieflorescontact left a comment

marieflorescontact Jan 29, 2025

CelineSebe Jan 29, 2025

marieflorescontact Jan 29, 2025

[frontend] Add a new relationship views in entities having an Attack Pattern Knowledge view (#8835) #9623

[frontend] Add a new relationship views in entities having an Attack Pattern Knowledge view (#8835) #9623

Conversation

CelineSebe commented Jan 16, 2025 • edited Loading

Proposed changes

Related issues

Checklist

Further comments

codecov bot commented Jan 22, 2025 • edited Loading

Codecov Report

SouadHadjiat Jan 24, 2025

Choose a reason for hiding this comment

marieflorescontact left a comment • edited Loading

Choose a reason for hiding this comment

CelineSebe commented Jan 27, 2025

marieflorescontact Jan 27, 2025

Choose a reason for hiding this comment

SouadHadjiat left a comment

Choose a reason for hiding this comment

marieflorescontact left a comment

Choose a reason for hiding this comment

marieflorescontact Jan 29, 2025

Choose a reason for hiding this comment

CelineSebe Jan 29, 2025

Choose a reason for hiding this comment

marieflorescontact Jan 29, 2025

Choose a reason for hiding this comment

CelineSebe commented Jan 16, 2025 •

edited

Loading

codecov bot commented Jan 22, 2025 •

edited

Loading

marieflorescontact left a comment •

edited

Loading